Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upload error #90

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Feature/upload error #90

merged 4 commits into from
Jul 5, 2024

Conversation

rernst
Copy link
Member

@rernst rernst commented Jul 4, 2024

  • Catch parsing errors and send email to lab.

@fdekievit
Copy link

Ziet er goed uit!

Mag er alleen aub nog een unittest bij die het try-catch block triggert?

@rernst rernst requested a review from fdekievit July 5, 2024 11:13
@rernst
Copy link
Member Author

rernst commented Jul 5, 2024

Mag er alleen aub nog een unittest bij die het try-catch block triggert?

Toegevoegd :)

fdekievit
fdekievit previously approved these changes Jul 5, 2024
Copy link

@fdekievit fdekievit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed, approved!

@fdekievit
Copy link

Reviewed, tests passed!

Copy link

@fdekievit fdekievit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Tests passed

@fdekievit fdekievit merged commit 09c0e50 into develop Jul 5, 2024
1 check passed
@fdekievit fdekievit deleted the feature/upload_error branch July 5, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants